dgram: reuseAddr/reusePort fixes #16677
Draft
+128
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 9:49 PM PT - Jan 23rd, 2025
❌ @heimskr, your commit 81e8362 has 3 failures in
🧪 try this PR locally: bunx bun-pr 16677 |
heimskr
requested review from
a team and
Jarred-Sumner
and removed request for
a team
DonIsaac
reviewed
Jan 24, 2025
| @@ -1279,6 +1289,11 @@ pub const ServerConfig = struct { | |||
| } | |||
| if (global.hasException()) return error.JSError; | |||
|
|
|||
| if (try arg.get(global, "ipv6Only")) |dev| { | |||
There was a problem hiding this comment.
I think there's a getOptionalBoolean function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the
reuseAddroption in node:dgram, and fixes the behavior ofreusePortto match the behavior in Node.js.How did you verify your code works?
I ran the code in #16133.